add local swiftlint analyzer script to mimic CI + add to gradlew#2135
Merged
add local swiftlint analyzer script to mimic CI + add to gradlew#2135
Conversation
sichanyoo
approved these changes
Apr 7, 2026
jbelkins
reviewed
Apr 7, 2026
| description = "Run swiftlint analyzer only (requires compilation)." | ||
| group = "Verification" | ||
| commandLine("bash", "scripts/swiftlint-ci.sh", "--analyze-only") | ||
| } |
Contributor
There was a problem hiding this comment.
We've never had Gradle tasks for swiftlint before... is there a reason we're adding them versus just calling the script directly?
Contributor
Author
There was a problem hiding this comment.
I thought it would make it easy/consistent to run since we already use a gradle task for ktlint (note this is just for local use and CI is not using it)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #
Description of changes
New/existing dependencies impact assessment, if applicable
Conventional Commits
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.